Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli issue 1234 #212

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Cli issue 1234 #212

merged 2 commits into from
Nov 11, 2022

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Nov 11, 2022 •
edited
Loading

Issue

sasjs/cli#1234

Intent

  • Combine configuration and target configs. Target configs should take precedence over configuration configs.

Implementation

  • Added ConfigTypes enum.
  • Added getConfig private method to Target class.
  • Added unit tests.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
  • All sasjs-cli unit tests are passing (npm test).
  • Reviewer is assigned.

@YuryShkoda YuryShkoda merged commit 65494b5 into main Nov 11, 2022
@YuryShkoda YuryShkoda deleted the cli-issue-1234 branch November 11, 2022 14:19
@sasjsbot
Copy link

🎉 This PR is included in version 2.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medjedovicm medjedovicm medjedovicm approved these changes

@VladislavParhomchik VladislavParhomchik Awaiting requested review from VladislavParhomchik

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuryShkoda @sasjsbot @medjedovicm